search

taljacobson / flutter_mailer

A wrapper on top of MFMailComposeViewController from iOS and Mail Intent on android
MIT License
47 stars 39 forks source link

Android: return succes onActivityForResult instead of after starting the intent. #16

Closed robindijkhof closed 4 years ago

robindijkhof commented 4 years ago

The send method should return success onActivityForResult. Currently it returns success after starting the intent. This gives the illusion the user is done sending. However, the user can still be in for example Gmail, or even has to pick an app to send the mail with.

taljacobson commented 4 years ago

A PR is most welcome.

On Sun, Dec 8, 2019, 17:30 robindijkhof notifications@github.com wrote:

The send method should return succes onActivityForResult. Currently it returns succes after starting the intent. This gives the illusion the user is done sending. However, the user can still be in for example Gmail, or even has to pick an app to send the mail with.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/taljacobson/flutter_mailer/issues/16?email_source=notifications&email_token=ADDQIUKGK5GQXGDDVJ5JEETQXUHIXA5CNFSM4JX5DBQKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H64WSLQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDQIUL4KCJN4ICAQWKSFFDQXUHIXANCNFSM4JX5DBQA .

taljacobson commented 4 years ago

thank you for the PR. i was only able to test it today. sorry for the delay. looks good to me.