search

taljacobson / flutter_mailer

A wrapper on top of MFMailComposeViewController from iOS and Mail Intent on android
MIT License
46 stars 35 forks source link

[ios] send result when mail has send #27

Closed robindijkhof closed 4 years ago

robindijkhof commented 4 years ago

fixes https://github.com/taljacobson/flutter_mailer/issues/26

robindijkhof commented 4 years ago

@taljacobson any idea why the labeler has failed?

taljacobson commented 4 years ago

firstly thank you for the PR.

as with the labeler, not sure yet. just gives an error of 

##[error]HttpError: Resource not accessible by integration

not a big deal if it doesn't work.

as for the PR, i wont have the ability to test it for on a ios device for atleast a week to QA it out. so might just merge and push as a dev release. if that is not a problem.

taljacobson commented 4 years ago

ok published as 0.5.1-dev.1.

with that im thinking we might make this a major release, with breaking changes. the ability to know if the email was sent, canceled or saved in ios could be very beneficial for some. the only draw back is the it is only possible in ios. for android we might just want to send a string of unknown | Android

by changing the dart send signature from a Future that returns <void> to <String> or provide a enum with Sent | Canceled | Draft | Android

robindijkhof commented 4 years ago

That 's fine

Op di 9 jun. 2020 22:32 schreef Tal Jacobson notifications@github.com:

firstly thank you for the PR.

as with the labeler, not sure yet. just gives an error of

[error]HttpError: Resource not accessible by integration

not a big deal if it doesn't work.

as for the PR, i wont have the ability to test it for on a ios device for atleast a week to QA it out. so might just merge and push as a dev release. if that is not a problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/taljacobson/flutter_mailer/pull/27#issuecomment-641553400, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJR665CLGYQ7APZ7YRYYYDRV2L7NANCNFSM4NZXPQIA .

robindijkhof commented 4 years ago

ok published as 0.5.1-dev.1.

with that im thinking we might make this a major release, with breaking changes. the ability to know if the email was sent, canceled or saved in ios could be very beneficial for some. the only draw back is the it is only possible in ios. for android we might just want to send a string of unknown | Android

by changing the dart send signature from a Future that returns <void> to <String> or provide a enum with Sent | Canceled | Draft | Android

guess that would be a useful feature. Unfortunately, I'm not an objective-c/swift developer. This PR literally took hours.

taljacobson commented 4 years ago

merged this as 0.5.1-dev.2 and published as 0.5.1-dev.2. will change to a non dev version soon.

if you can use the dev version and report back that it works as intended on a physical device, that would be much apriciated.

robindijkhof commented 4 years ago

I tested my branch on a physical device. Are there any other changes?

taljacobson commented 4 years ago

none other then pubspec and changelog.

taljacobson commented 4 years ago

published as 0.5.1 no need for a dev version