search

taljacobson / flutter_mailer

A wrapper on top of MFMailComposeViewController from iOS and Mail Intent on android
MIT License
47 stars 39 forks source link

For iOS, don't return the feedback MFMailComposeResult result #31

Closed herveperoteau closed 4 years ago

herveperoteau commented 4 years ago

Hi,

For iOS, in the MFMailComposeViewControllerDelegate, you don't return the feedback MFMailComposeResult result. It could be easily by keep the result:(FlutterResult)result in a variable and call it in the MFMailComposeViewControllerDelegate method.

taljacobson commented 4 years ago

yes there is a pending PR #28 i made to return the result.

i have not been able to properly test it though due to issues with my physical device, i did make it available on pub with a dev version of 0.6.0-dev.1.

hopefully i will be able to test and merge it soon.

herveperoteau commented 4 years ago

Ok I could test it on device

What is the correct syntax to use in my yaml to use your branch ?

flutter_mailer: ^0.4.1+1

flutter_mailer: https://github.com/taljacobson/flutter_mailer/tree/MailerResponse

On 30 Jul 2020, at 13:15, Tal Jacobson notifications@github.com wrote:

yes there is a pending PR #28 https://github.com/taljacobson/flutter_mailer/pull/28 i made to return the result.

i have not been able to properly test it though due to issues with my physical device, i did make it available on pub with a dev version of 0.6.0-dev.1.

hopefully i will be able to test and merge it soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/taljacobson/flutter_mailer/issues/31#issuecomment-666304480, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXAWXCEWJSSENBNT2IBXQDR6FI3PANCNFSM4PNO3TMA.

herveperoteau commented 4 years ago

Missing } in your branch

On 30 Jul 2020, at 13:15, Tal Jacobson notifications@github.com wrote:

yes there is a pending PR #28 https://github.com/taljacobson/flutter_mailer/pull/28 i made to return the result.

i have not been able to properly test it though due to issues with my physical device, i did make it available on pub with a dev version of 0.6.0-dev.1.

hopefully i will be able to test and merge it soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/taljacobson/flutter_mailer/issues/31#issuecomment-666304480, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXAWXCEWJSSENBNT2IBXQDR6FI3PANCNFSM4PNO3TMA.

herveperoteau commented 4 years ago

After the fix of missing } it’s works as expected on iOS device. (See my screenshot)

Did you know when you could published it ? Because I need this feature quickly. Please give me a feedback

Thanks Hervé

On 30 Jul 2020, at 13:30, herve peroteau herve.peroteau@gmail.com wrote:

Missing } in your branch

<Screenshot 2020-07-30 at 13.29.16.png>

On 30 Jul 2020, at 13:15, Tal Jacobson <notifications@github.com mailto:notifications@github.com> wrote:

yes there is a pending PR #28 https://github.com/taljacobson/flutter_mailer/pull/28 i made to return the result.

i have not been able to properly test it though due to issues with my physical device, i did make it available on pub with a dev version of 0.6.0-dev.1.

hopefully i will be able to test and merge it soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/taljacobson/flutter_mailer/issues/31#issuecomment-666304480, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXAWXCEWJSSENBNT2IBXQDR6FI3PANCNFSM4PNO3TMA.

taljacobson commented 4 years ago

ok published a new dev version 0.6.0-dev.2, please try it out,

herveperoteau commented 4 years ago

It works well Thanks

On 30 Jul 2020, at 14:35, Tal Jacobson notifications@github.com wrote:

ok published a new dev version 0.6.0-dev.2, please try it out,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/taljacobson/flutter_mailer/issues/31#issuecomment-666337432, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXAWXGYMPB64LIBXXFFC4DR6FSIXANCNFSM4PNO3TMA.