search

talk-to / Chocolate

Make Cocoa more fun
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Add methods for working with temporary files, and writing binary plists #69

Closed mx4492 closed 10 years ago

mx4492 commented 10 years ago

These are two PRs in one because the second commit has a dependency on the first.

chaitanyagupta commented 10 years ago

GTM

mx4492 commented 10 years ago

Missing assertion on path

  • As of today, I'm not convinced of the relative merit of having blanket asserts for all arguments (which is almost always the case).
  • Such asserts are not a currently a practice for Chocolate (there are only a couple such in place).

Still, if you think that we should add parameter-asserts going forward, then I'll make these changes. But note that we will not be able to use TDTParameterAssert for block, because that is part of testing additions (which does not take a dependency on the foundation additions).

chaitanyagupta commented 10 years ago

These are not really blanket assertions. A nil value doesn't make any sense here. If the app doesn't crash, you will end up with a hard to debug issue.

mx4492 commented 10 years ago

Updated. I've used an NSParameterAssert for the method in testing additions.