search

talker93 / 2022-MUSI6106

Template project for assignments and exercises for the class MUSI6106
GNU General Public License v3.0
0 stars 0 forks source link

Assignment1 combfilter #2

Open talker93 opened 2 years ago

talker93 commented 2 years ago

Hi all, thanks for your reviewing, I'm far from good yet, but everything is improving!

thiago-roque07 commented 2 years ago

Hi Shan.

As I mentioned to you in class, I don't have much to add apart from Vedant's comments. Apart from the fact that you didn't used the CombFilter and CombFilterIf, which was a requirement, I liked your code structure. Your idea of using as a workaround for the ringbuffer was quite clever (although we were supposed to use ringbuffer). From the user point of view, I liked the way to presented to the user how he should input the arguments. I'll probably add something like that on my own code!