search

talker93 / 2022-MUSI6106

Template project for assignments and exercises for the class MUSI6106
GNU General Public License v3.0
0 stars 0 forks source link

A2: avoid code duplication #28

Open alexanderlerch opened 2 years ago

alexanderlerch commented 2 years ago

https://github.com/talker93/2022-MUSI6106/blob/84e2e2276f3a4a33f739936d3e52c62b53201de2/src/Vibrato/Vibrato.cpp#L83

even if you choose to set parameters in both init and setParam, I would at least call the setParam function from init to avoid duplicate code (and not vice versa!)