fix(gcloud): support cloudrun apps without env vars

talkiq / circleci-orbs

Various CircleCI orbs shared across TalkIQ projects

2 stars 4 forks source link

fix(gcloud): support cloudrun apps without env vars #109

Closed TheKevJames closed 1 year ago

TheKevJames commented 1 year ago

Summary

See https://dialpad.slack.com/archives/GA91FTLDU/p1673464449394329

Checklist

[x] My comments/docstrings/type hints are clear
[x] I've written new tests or this change does not need them
[x] I've tested this manually
[x] The architecture diagrams have been updated, if need be
[x] I've included any special rollback strategies above
[x] Any relevant metrics/monitors/SLOs have been added or modified
[x] I've notified all relevant stakeholders of the change
[x] I've updated .github/CODEOWNERS, if relevant

TheKevJames commented 1 year ago

@shaundialpad looks like that behaviour has since changed:

» gcloud run deploy --help | grep -A2 set-env-vars
       --set-env-vars=[KEY=VALUE,...]
          List of key-value pairs to set as environment variables. All existing
          environment variables will be removed first.

shaundialpad commented 1 year ago

@shaundialpad looks like that behaviour has since changed:

» gcloud run deploy --help | grep -A2 set-env-vars
       --set-env-vars=[KEY=VALUE,...]
          List of key-value pairs to set as environment variables. All existing
          environment variables will be removed first.

Ohh! Thanks very much for pointing this out