talkiq / circleci-orbs

Various CircleCI orbs shared across TalkIQ projects
2 stars 4 forks source link

feat(gcloud): namespace prev_version by cluster on deploy #129

Closed jonathan-johnston closed 9 months ago

jonathan-johnston commented 9 months ago

Summary

For GKE deployments which are deployed to different clusters within the same workflow, referring to prev_version in a subsequent workflow step fails due to contention and overwrites. To resolve this we should namespace by cluster when storing the previous GKE deployment version.

Custom Checklist Items

Standard Checklist

jonathan-johnston commented 9 months ago

Running testing on this orb now.

Edit: tested and works as expected

jonathan-johnston commented 9 months ago

IMO this should be a major version bump because we'll have to point to the cluster-scoped prev_version when running our slack notifs.