Unset default memory on GCF deploy and upload from file path. These settings have interfered with required settings in Terraform (which is required for VPC connector, PubSub triggers) and caused the source of truth for GCFs to be split across more than one repo. This change addresses that by making the deploy operation simpler and change nothing about the GCF config.
One thing I don't like about this proposal is that this only accounts for memory as being the point of possible discrepancies between TF & CI. What if there are other parameters that come along that we add? Will this hidden dependency hit us again?
What if instead we have a "trigger-only" mode that explicitly does not update any of the other parameters? That would make it abundantly clear that it won't modify your function's settings. It would also make it clear in tooling that we are trying to avoid changing any settings.
Checklist
[x] My comments/docstrings/type hints are clear
[ ] I've written new tests or this change does not need them
[x] I've tested this manually
[ ] The architecture diagrams have been updated, if need be
[ ] I've included any special rollback strategies above
[ ] Any relevant metrics/monitors/SLOs have been added or modified
[x] I've notified all relevant stakeholders of the change
Summary
Unset default memory on GCF deploy and upload from file path. These settings have interfered with required settings in Terraform (which is required for VPC connector, PubSub triggers) and caused the source of truth for GCFs to be split across more than one repo. This change addresses that by making the deploy operation simpler and change nothing about the GCF config.
One thing I don't like about this proposal is that this only accounts for memory as being the point of possible discrepancies between TF & CI. What if there are other parameters that come along that we add? Will this hidden dependency hit us again?
What if instead we have a "trigger-only" mode that explicitly does not update any of the other parameters? That would make it abundantly clear that it won't modify your function's settings. It would also make it clear in
toolingthat we are trying to avoid changing any settings.Checklist