search

talkiq / confluence-wiki-sync

https://github.com/marketplace/actions/confluence-docs-sync
Other
11 stars 3 forks source link

Links to GitHub are messed up #36

Closed KevinGDialpad closed 2 years ago

KevinGDialpad commented 2 years ago

Similar to #34

Another problem with relative links...

When linking to GitHub we do:

links_to_replace[link] = gh_root + target_path

But target_path is the absolute path of the target file on the machine that's running the script instead of the path relative to the repo root.

So you end up with a link to https://github.com/<org>/<repo>/blob/HEAD//github/workspace/docs/README.rst instead of https://github.com/<org>/<repo>/blob/HEAD/docs/README.rst

KevinGDialpad commented 2 years ago

I think this problem was hidden until we moved from Alpine to Debian :(