Accept the official format for `STORAGE_EMULATOR_HOST` env var

talkiq / gcloud-aio

(Asyncio OR Threadsafe) Google Cloud Client Library for Python

https://talkiq.github.io/gcloud-aio

276 stars 91 forks source link

Accept the official format for `STORAGE_EMULATOR_HOST` env var #632

Closed guneemwelloeux closed 1 year ago

guneemwelloeux commented 1 year ago

Summary

In order for this library to be compatible with the official python Google Cloud Storage library, it needs to accept the same value for configuring the STORAGE_EMULATOR_HOST environment variable. This will allow users to rely on both libraries in a single project.

Fixes: https://github.com/talkiq/gcloud-aio/issues/631

leanaha commented 1 year ago

Thank you! :-)

guneemwelloeux commented 1 year ago

Hello,

When could we expect this to be merged and a new version of the package to be released on PyPI?

Thanks

TheKevJames commented 1 year ago

@guneemwelloeux sorry for fallign behind on reviews here, supporting both flows indeed makes sense. We can't use removeprefix, as it's py39+ (our next release drops 37, but we do still need py38 support), so I'll add a quick deprecation warning here and aim to get this released right away.