talkiq / gcloud-aio

(Asyncio OR Threadsafe) Google Cloud Client Library for Python
https://talkiq.github.io/gcloud-aio
270 stars 89 forks source link

fix(bigquery) Add location for Big Query job #658

Closed manhld0206 closed 6 months ago

manhld0206 commented 9 months ago

Summary

What changed

Why

spencertollefson commented 8 months ago

Oh nice, I totally missed your PR here @manhld0206! I made one as well, but yours looks more comprehensive than the one I made: https://github.com/talkiq/gcloud-aio/pull/666.

Looks like you haven't gotten any response from reviewers yet. @TheKevJames @cphoward @aherrada-dialpad @leanaha @eddiedialpad @juanamari94

manhld0206 commented 7 months ago

@TheKevJames May I ask for your help to run the test cases?

moiseenkov commented 7 months ago

@overset , @kmorey , @cphoward, @aherrada-dialpad, hi everyone! Could you please take a look at this PR and merge it if possible. Any response and releasing this feature is highly appreciated.

TheKevJames commented 6 months ago

Sorry for the big delay on this, really appreciate the contribution(s) here. This approach looks great! I'll toss a few tests at it and get it merged asap.

@spencertollefson to answer your question on the other PR, we'd definitely like to head in the direction of supporting all available API params, if a solution could be built which is reasonable maintainable (eg. perhaps we can auto-build some code based off of their API specs, or such!). Definitely would want that to be a separate PR, as it'd likely be a pretty large change, but we'd definitely be interested in looking more into it! It's been a moonshot backlog item for us for a while, but we haven't had the bandwidth to build it in-house :)