search

talkiq / gcloud-aio

(Asyncio OR Threadsafe) Google Cloud Client Library for Python
https://talkiq.github.io/gcloud-aio
270 stars 89 forks source link

fix(bigquery) Add location param to BigQuery Job #666

Closed spencertollefson closed 7 months ago

spencertollefson commented 8 months ago

Bigquery Job has been missing the location param. Sometimes this param is required, as can be seen in the link above the get_job() func definition.

Summary

I added a small code change here, which, if I understand correctly, should fix the issue described in #584 .

I tried to make some unit tests, and frankly felt a little over my head so I stopped (between lack of other tests, asyncio, and making network calls to GCP). I thought I'd get the PR up and could start a discussion if we can try merging this in without unit tests - let me know.

EDIT: I was also thinking this PR could be used to expand the Job() class to allow for all of the query parameters that Google has as options in their API for the various Job methods. Let me know if that is something to be implemented here, or saved for another PR.

Originally I was notified of this issue by this issue in the Airflow repository: https://github.com/apache/airflow/issues/35833

moiseenkov commented 7 months ago

@overset , @kmorey , @bhearsum , hi, Could you please take a look at this PR and merge it if possible?

spencertollefson commented 7 months ago

@moiseenkov - I appreciate the review, but I think @manhld0206 has a better PR here addressing the same issue: https://github.com/talkiq/gcloud-aio/pull/658

I'll close my PR, and steer you and the other PRs to that one.