search

talkjs / country-flag-emoji-polyfill

Add country flag emojis to Chromium-based browsers on Windows
Other
122 stars 8 forks source link

Migrate to unbuild #13

Closed DanielleHuisman closed 6 months ago

DanielleHuisman commented 6 months ago

Fixes #8.

By using unbuild, this package should work for both ESM and CJS environments. I published the new package build for testing under @daniellehuisman/country-flag-emoji-polyfill (please don't use this package as a dependency in production, but wait for this PR to be merged).

DanielleHuisman commented 6 months ago

That said, can you tell me a little bit more about how confident you are that unbuild's output will work with generally everybody's setup? Thing is, that's microbundle's promise too (though clearly that wasn't correct) and I hadn't heard of unbuild before. Also their README is extremely light on details or even its raison d'etre. Any context would be warmly appreciated!

Unbuild is a small wrapper around the Rollup tool to reduce configuration. I don't really have an opinion on using microbundle or unbuild, but I know unbuild worked well for fixing a similar issue in vite-plugin-graphql-codegen.