talklittle / reddit-is-fun

OLD VERSION 1.3 of reddit is fun -- Android app to interact with reddit.com
GNU General Public License v3.0
371 stars 158 forks source link

Force closes using cyanogen and apps2sd #13

Closed talklittle closed 14 years ago

talklittle commented 14 years ago

A number of users have been reporting force closes when using CyanogenMod and apps2sd, usually when returning to the Activity from another activity (viewing a link in browser then returning)

Unfortunately I don't use cyanogen or apps2sd and can't reproduce the bug. Would anyone mind checking this out please? :)

I wonder if running TaskKiller to free up some memory would help?

EDIT: Ok, I'm going to try switchrom.sh (http://forum.xda-developers.com/showpost.php?p=4209412) and debug it myself...

EDIT2: Got cyanogen installed, with its automatic apps2sd stuff. I have now indeed encountered force closes that I didn't encounter with stock rom. They mostly happen when rotating the screen. Happened again when rotating screen with login dialog onscreen. Also I get a weird bug where it doesn't load the threads list correctly the first time, and I have to refresh to get anything to show up.

talklittle commented 14 years ago

Fixed all the bugs I could find. Many NullPointerExceptions due to weird Android behavior of trying to do onPrepareDialog for every dialog that had ever been shown by that Activity, every time you rotate the phone or returned to the activity from another. I guess this behavior changed between 1.5 and 1.6? Possibly race condition? Also fixed bug caused by HttpClient using single-threaded version (switched to multi-threaded version). Again, was not a problem in stock 1.5 rom.