search

talklittle / reddit-is-fun

OLD VERSION 1.3 of reddit is fun -- Android app to interact with reddit.com
GNU General Public License v3.0
372 stars 157 forks source link

Left handed mode #202

Open talklittle opened 12 years ago

talklittle commented 12 years ago

"You know how the voting arrows are on the left and the pictures that you click on are on the right? Well, could you possibly make a left handed option that will reverse them?"

fmichea commented 12 years ago

Hi talklittle,

I am not left handed but I was curious of android and wanted to help you, so I implemented this mode. The things I have reversed: comment dialog, thread dialog and thread item. I should say that I am discovering android, Java and your code, so I probably missed things (bugs?). This is why I am commenting this feature request instead of doing a pull request.

Could you take a look at what I did to see if it is good or if there is still some work to do? It's on my fork.

Regards,

talklittle commented 12 years ago

Hi kushou, thanks a lot! I'll have time to take a look within a few days.

fmichea commented 12 years ago

Hey talklittle! I hope you are ok. Two things:

1/ Wow, you worked a lot. Awesome. But now my branch is completly out-of-date. I will rebase it tonight, but it's a bit difficult (already tried once, failed, I will restart from the beginning after posting this).

2/ I found a left-handed redditor friend with an android phone (eheh) that agreed to test the mode, but I don't know if he will use it a lot. Do you have any idea to make sure that the mode is OK?

Have a nice evening!

talklittle commented 12 years ago

Kushou, thank you very much, I am grateful for your contribution. But please hold off on this work. I am rewriting the app from scratch and probably get rid of the GPL license since I am finding GPL way too overbearing. Sorry for this, but let's put it on hold for now. Thanks again.

fmichea commented 12 years ago

Ah oh ok, no problem. Hmmm can we help with new app?

talklittle commented 12 years ago

Thanks for understanding. I would love to get some help on the new app but unfortunately I haven't decided how exactly to deal with the new source yet--I think I'll work on it by myself for now.

One thing is if you can submit patches for the current version (v1) and license your patches to me in a non-GPL way, then I can maybe incorporate them in v2 and list you as a contributor. Unfortunately it's too early for me to guarantee that I'll use any contributed code, which is why I think it's better to wait for now. Thank you.

fmichea commented 12 years ago

I will just work on my personnal work and see what happens. If I can help when v2 will be out, I will. For now, I will just follow what happens to this project and wait.