search

talklittle / thumbnex

Elixir library to create thumbnails from images and video screenshots.
https://hexdocs.pm/thumbnex/
MIT License
71 stars 7 forks source link

Better Error Reporting #15

Closed benitezhm closed 1 year ago

benitezhm commented 1 year ago

First of all, thank you for this library, we are using it in our projects and recently we faced an issue that bring us to this pr,

Bit of context: If for any reason the thumbnail generation fails, (due to let's say invalid or corrupted video file) the library will crash, without giving the opportunity to the service who uses the library to control the error, with these changes we pretend to forward whatever error is to the main service so the service can decide what to do with it.

List of changes:

Refactored some functions to report errors back Mix format applied Added couple of test to match the errors reports Added rambo to the list of compilers so it gets installed on mix compile (needed for mac os arm processors)

talklittle commented 1 year ago

Thanks for the PR, looks like some good improvements, after a brief glance.

talklittle commented 1 year ago

Thank you for the pull request.