search

talkol / spiderman

Spider-Man VR Experience
https://spiderman.webvr.link
MIT License
140 stars 45 forks source link

Add correct attributions to README #2

Closed Galadirith closed 4 years ago

Galadirith commented 4 years ago

@talkol You've created amazing work here, it's a really fun experience 😊

I found that you have used several assets in your WebXR app that are created by others, some you provide incomplete credits for in your README.md others you don't credit. A couple that I noticed were the "Crystal Kyber" by Ian Diaz which seems to be used mostly unmodified and incompletely credited and "Spider-Man:Interactive View" by Pawas Saxena where you have cropped most of the model out to leave only the hands and added your own hand animations (did you create the animations yourself?) which you haven't credited.

I would like to suggest changes for the credits for these two sets of Creative Commons assets (Frequently Asked Questions, Best practices for attribution)

"Crystal Kyber" by Ian Diaz licensed under CC BY 4.0 / Source assets are compressed

leftHand.glb and rightHand.glb are a derivative of "Spider-Man:Interactive View" by Pawas Saxena licensed under CC BY 4.0

You have also copied in several pieces of source code from A-Frame, for example hand.js is mostly the same as hand-controls.js. A candidate credit could be

This repository incorporates code from aframe which is release under the MIT license.

and ideally you would also include A-Frames LICENSE in your repo since you do use large blocks of code. You could add the copyright notice from LICENSE to the beginning of any source files that are majority code from aframe or just include it in your LICENSE.md.

The license of the assets that you've used that are created by others that I've found require you to add proper attribution. I completely appreciate that writing full attributions is tedious, and I know there is certainly no bad intent on your part since you have tried to give attribution. But regardless of what is required, it would be very thoughtful and respectful to recognise and fully attribute the awesome work by others that has gone in to creating your amazing experience 😊

I would also suggest adding complete attributions for the other assets you have used that are created by others.

talkol commented 4 years ago

lol, thanks! I'll add your suggestions, thanks for taking the time to get all the correct ones!

talkol commented 4 years ago

I'm awestruck by how you found all of those, that's some world class reverse engineering.. you nailed all the assets by third parties

Galadirith commented 4 years ago

@talkol Thank you so much for adding those attributions so quickly, I really appreciate it. I only really noticed them because I was digging around in your source code so much. I really love the experience and I wanted to understand more about how you did it. Not everyone shares their source code so I am really really grateful 😊

The bit I really wanted to learn about was your movement mechanics. I usually get motion sickness when I don't use teleport controls, but for some reason in your Spiderman experience my motion sickness almost disappeared. I can even jump over buildings without too much issue.

highrise

I think this might have something to do with your smooth controls you mentioned. I definitely want to study your code more to understand your implementation. Whatever the reason is I'm just so glad I get to experience this without any real motion sickness 😊