search

talkpython / async-techniques-python-course

Async Techniques and Examples in Python Course
https://training.talkpython.fm/courses/explore_async_python/async-in-python-with-threading-and-multiprocessing
MIT License
444 stars 244 forks source link

Possibly remove `cchardet` dependency? #19

Open serixscorpio opened 1 year ago

serixscorpio commented 1 year ago

aiohttp stopped installing cchardet speedup under >Python 3.9 (See https://github.com/aio-libs/aiohttp/pull/6857) due to cchardet being unmaintained. I ran async_scrape/program.py successfully without cchardet using python 3.9 and 3.10. I'll send a PR if it makes sense to remove cchardet from the requirements.txt.

https://github.com/talkpython/async-techniques-python-course/blob/dddaba4e13665c27002f1ee79f17914caab5cd99/src/04-asyncio/web_scraping/async_scrape/requirements.txt#L5

mikeckennedy commented 1 year ago

Thanks for the heads up. Yes, send me a PR and I'll gladly accept it.