search

talkpython / async-techniques-python-course

Async Techniques and Examples in Python Course
https://training.talkpython.fm/courses/explore_async_python/async-in-python-with-threading-and-multiprocessing
MIT License
455 stars 250 forks source link

Use self.loop.create_task #6

Closed NissesSenap closed 6 years ago

NissesSenap commented 6 years ago

Fixes #5 Creating a class and make the eventloop avliable with self. Call it in the get_title_range function.

mikeckennedy commented 6 years ago

Hi. I appreciate this PR. But it's too much of a change from the original code typed during the video. If you want to make the loop accessible because it's needed per #5 (I think this may be an older version of Python you have?) just make the loop a global variable. I'd be willing to accept that as a PR.

NissesSenap commented 6 years ago

Haha for some reason i didn't think of a global variabel :)