search

talkpython / python-for-absolute-beginners-course

Code samples and other handouts for our course.
https://training.talkpython.fm/courses/explore_beginners/python-for-absolute-beginners
MIT License
2.3k stars 1k forks source link

Refactor a reference to label rolls #31

Closed bitbytes01 closed 3 years ago

bitbytes01 commented 3 years ago

Keeping labels of lists consistent. Previous label was rolls, during lesson refactor edit label to roll_names. 1 label was missed.

mikeckennedy commented 3 years ago

Hi. I'm guessing this is meant to go back to your fork. We generally don't accept PRs that make changes to the content of the code unless there is a true bug. We want what is in the repo to be as close as possible to what students see on the screen. Is there a problem I missed?

bitbytes01 commented 3 years ago

Oh, I see, you want to mirror what I see on the video. Then if that is the case, there is no issue. Please close my PR.

However, can you help me understand but do you provided the solution for the practices? I'm on Ch 7 for the beginner course. I thought that I could compare what I wrote for an answer to a provided file. But I didn't seem to find one that mirror the practice for ch 7. Please advise.

On Mon, Dec 7, 2020 at 10:44 AM Michael Kennedy notifications@github.com wrote:

Hi. I'm guessing this is meant to go back to your fork. We generally don't accept PRs that make changes to the content of the code unless there is a true bug. We want what is in the repo to be as close as possible to what students see on the screen. Is there a problem I missed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/talkpython/python-for-absolute-beginners-course/pull/31#issuecomment-740105478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6P5FATCKBBR4ERGVVEK5LSTUO7DANCNFSM4UP4JNCA .

-- Respectfully Mr Israel Luna

mikeckennedy commented 3 years ago

Ok, I'll close it. You can find all the solutions over here.

https://github.com/talkpython/python-for-absolute-beginners-course/tree/master/solutions

:)

bitbytes01 commented 3 years ago

Awesome! Thanks so much.

On Mon, Dec 7, 2020 at 12:45 PM Michael Kennedy notifications@github.com wrote:

Ok, I'll close it. You can find all the solutions over here.

https://github.com/talkpython/python-for-absolute-beginners-course/tree/master/solutions

:)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/talkpython/python-for-absolute-beginners-course/pull/31#issuecomment-740169904, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6P5FESBNXBUZAUWRS7XZTSTU5F3ANCNFSM4UP4JNCA .

-- Respectfully Mr Israel Luna