search

tallakt / codepagex

Elixir string encoding conversion - like iconv but pure Elixir
Other
108 stars 20 forks source link

Dangerous code path: Codepage.to_string calls Mappings.to_string that calls String.to_atom #9

Closed heri16 closed 8 years ago

heri16 commented 8 years ago

String.to_atom seems exposed to the user. Can we replace this with String_to_existing_atom?

https://github.com/tallakt/codepagex/blob/master/lib/codepagex/mappings.ex#L176

tallakt commented 8 years ago

No. I believe it is only exposed to the user of the library, used only during compilation.