search

tallakt / modbus-cli

Modbus command line utility
102 stars 19 forks source link

Added --port option for overriding default Modbus TCP port 502 #4

Closed alt219 closed 12 years ago

alt219 commented 12 years ago

Hello tallakt,

I found modbus-cli to be pretty useful in a recent project, but needed to use some non-standard ports for development and testing, so I added an optional --port argument for specifying the TCP port to use.

Thanks for the good work on modbus-cli!

Sincerely,

Ebon

alt219 commented 12 years ago

Oh sorry for the 8 commits, I should've flattened the merge from the feature branch I was working on. If that's more convenient for you, I can close the pull request and re-request with a flattened commit...

tallakt commented 12 years ago

Hi

I cant believe I forgot the port option :)

I will review and most likely add your patch when I have some time. You might also want to check out the bug list if you use modbus-cli, there are a few issues not addressed yet

Thanks!

Tallak

Den 29. des. 2011 kl. 02:06 skrev alt219reply@reply.github.com:

Hello tallakt,

I found modbus-cli to be pretty useful in a recent project, but needed to use some non-standard ports for development and testing, so I added an optional --port argument for specifying the TCP port to use.

Thanks for the good work on modbus-cli!

Sincerely,

Ebon

You can merge this Pull Request by running:

git pull https://github.com/alt219/modbus-cli master

Or you can view, comment on it, or merge it online at:

https://github.com/tallakt/modbus-cli/pull/4

-- Commit Summary --

  • Add parameter for TCP port
  • Modify read tests to include TCP port
  • Modify write tests to include TCP port
  • Modify dump tests to include TCP port
  • Add port option for TCP port to use
  • Add port option for read command
  • Add port option for write command
  • Add port option for dump command

-- File Changes --

M lib/modbus-cli/commands_common.rb (4) M lib/modbus-cli/dump_command.rb (4) M lib/modbus-cli/read_command.rb (5) M lib/modbus-cli/write_command.rb (3) M spec/dump_command_spec.rb (28) M spec/read_command_spec.rb (40) M spec/spec_helper.rb (4) M spec/write_command_spec.rb (26)

-- Patch Links --

https://github.com/tallakt/modbus-cli/pull/4.patch https://github.com/tallakt/modbus-cli/pull/4.diff

Reply to this email directly or view it on GitHub: https://github.com/tallakt/modbus-cli/pull/4