search

tallbl0nde / TriPlayer

A feature-rich background audio player for Nintendo Switch (requires Atmosphere)
MIT License
174 stars 23 forks source link

Adding Missing Text #28

Closed Heartbeat-Heartbreak closed 3 years ago

Heartbeat-Heartbreak commented 3 years ago

That's what I wanted to talk to you about. If you don't add the missing text to example.json, then other translators can not to fully translate it.

tiansongyu commented 3 years ago

This is the reason. use not defined value. https://github.com/tallbl0nde/TriPlayer/blob/4e5ee19c992eba033b57444b7f4b312acf339163/Application/source/ui/frame/ArtistInfo.cpp#L186

not defined the "Common.Searching" https://github.com/tallbl0nde/TriPlayer/blob/4e5ee19c992eba033b57444b7f4b312acf339163/Application/romfs/lang/en.json#L62-L116

👀

tallbl0nde commented 3 years ago

Thanks, I have fixed this locally but just haven't pushed it yet. I'll merge yours in still :)