Always use ResourceManager instead of ..._properties.INSTANCE

tallence / core-forms

A simple and lean formeditor for the CoreMedia CMS.

Apache License 2.0

19 stars 12 forks source link

Always use ResourceManager instead of ..._properties.INSTANCE #7

Closed fwienber closed 6 years ago

fwienber commented 6 years ago

Using ResourceManager.getInstance().getString(bundle, key) instead of _properties.INSTANCE[key] provides better IDE support:

Code is green even before building the module
usage search of keys in properties files
always up-to-date when changing properties files

Also, you are already using resourceManager in MXML expressions, so using it in (static) ActionScript code, too, is more consistent.

fwienber commented 6 years ago

Cool, you really did it and made this Open Source! Code looks really nice and clean - like! This PR solves the only thing that is red in IDEA right after check-out. Your code relies on _properties classes being generated from the .properties files, which works, but using ResourceManager does have some advantages (see PR text above).

timolemke commented 6 years ago

Thanks a lot for the feedback and the fix!