search

talleyhoe / google-image-scraper

Simple google images scraper without chromium
GNU General Public License v3.0
19 stars 6 forks source link

Advanced search filters #1

Open rabbitflyer opened 9 months ago

rabbitflyer commented 9 months ago

Added a bunch of arguments corresponding to the various advanced image search filters and the safesearch setting.

talleyhoe commented 9 months ago

Hey, I'm pretty busy this week so I probably won't have time to review/merge until the weekend. Great idea! At first glance, code looks good. Thanks for following the style :)

talleyhoe commented 9 months ago

There's 2 big issues that have to be fixed (I'll help)

1.) The filters should all be optional

2.) Each option needs to be tested. This includes all of the choices for categorical arguments (large, medium, tall, square, etc)

3.) Plz try to avoid rows longer than 80 columns

rabbitflyer commented 7 months ago

Sorry, haven't revised/added anything, but realized that this can't be merged until it's "marked as ready".