search

tallforasmurf / PPQT

A post-processing tool for PGDP written in Python, PyQt4, and Qt
GNU General Public License v3.0
4 stars 2 forks source link

removing end of line spaces #111

Closed bibimbop closed 11 years ago

bibimbop commented 11 years ago

End of line spaces should be automatically removed on saving, like some editors do. I see no reason to keep them around.

tallforasmurf commented 11 years ago

Removing end of line spaces is a normal part of the "fixup" steps (guiguts fixup menu item, PPQT extras/fixupRE). I'd personally be very unhappy with an editor that did this automatically, but obviously opinions vary on that.

As a practical matter, I do not want to add a whole-document line by line pass to the save. Currently document save is just two lines of code,

    dataStream << self.toPlainText()
    dataStream.flush()

so all happening in the C++ code of QTextEdit and very quick even for large documents. Adding what would in effect be a "find/replace-all" macro to this would (a) slow it down and (b) add complexity to both pqEdit and pqFind, the only benefit being to replace a simple step of the normal workflow.