talmolab / sleap

A deep learning framework for multi-animal pose tracking.
https://sleap.ai
Other
435 stars 97 forks source link

Set `split_by_inds`, `test_labels`, and `validation_labels` to default (GUI) #1331

Closed roomrys closed 1 year ago

roomrys commented 1 year ago

Description

1053 allowed some unseen parameter to be used in GUI training when a trained model was used as a template. While certain parameters were set to defaults, others were controversially left to the values used in the trained model.

This PR sets more parameters to defaults, namely

which aims to ensure training is run on the labels in the current project. #1324 attempted to give the GUI user a bit more control, but ultimately it was decided that #1324 might cause more confusion than clarity.

Types of changes

Does this address any currently open issues?

Outside contributors checklist

Thank you for contributing to SLEAP!

:heart:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1331 (5300223) into develop (4525462) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1331      +/-   ##
===========================================
- Coverage    72.66%   72.66%   -0.01%     
===========================================
  Files          133      133              
  Lines        23675    23678       +3     
===========================================
+ Hits         17204    17206       +2     
- Misses        6471     6472       +1     
Impacted Files Coverage Δ
sleap/gui/learning/dialog.py 67.67% <100.00%> (-0.01%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more