talmolab / sleap

A deep learning framework for multi-animal pose tracking.
https://sleap.ai
Other
435 stars 97 forks source link

Fix `Filedialog` to work across (mac)OS #1393

Closed roomrys closed 1 year ago

roomrys commented 1 year ago

Description

Previously, we would use the directory keyword occasionally when calling certain FileDialog methods. The directory keyword is not able to be used on macOS, but the dir keyword seems to work well across all OS's (Windows, Mac, and Linux).

This PR substitutes the directory keyword with dir instead when calling FileDialog methods.

No automated tests, but manually tested the Save Configuration button on all three OS's.

Types of changes

Does this address any currently open issues?

Outside contributors checklist

Thank you for contributing to SLEAP!

:heart:

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@1c2be11). Click here to learn what that means. The diff coverage is 76.00%.

@@            Coverage Diff             @@
##             develop    #1393   +/-   ##
==========================================
  Coverage           ?   72.73%           
==========================================
  Files              ?      133           
  Lines              ?    23718           
  Branches           ?        0           
==========================================
  Hits               ?    17252           
  Misses             ?     6466           
  Partials           ?        0           
Impacted Files Coverage Δ
sleap/gui/dialogs/formbuilder.py 90.02% <0.00%> (ø)
sleap/gui/learning/dialog.py 67.72% <0.00%> (ø)
sleap/gui/dialogs/filedialog.py 54.16% <86.36%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more