Closed roomrys closed 1 year ago
:exclamation: No coverage uploaded for pull request base (
develop@1c2be11
). Click here to learn what that means. The diff coverage is76.00%
.
@@ Coverage Diff @@
## develop #1393 +/- ##
==========================================
Coverage ? 72.73%
==========================================
Files ? 133
Lines ? 23718
Branches ? 0
==========================================
Hits ? 17252
Misses ? 6466
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
sleap/gui/dialogs/formbuilder.py | 90.02% <0.00%> (ø) |
|
sleap/gui/learning/dialog.py | 67.72% <0.00%> (ø) |
|
sleap/gui/dialogs/filedialog.py | 54.16% <86.36%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Description
Previously, we would use the
directory
keyword occasionally when calling certainFileDialog
methods. Thedirectory
keyword is not able to be used on macOS, but thedir
keyword seems to work well across all OS's (Windows, Mac, and Linux).This PR substitutes the
directory
keyword withdir
instead when callingFileDialog
methods.No automated tests, but manually tested the Save Configuration button on all three OS's.
Types of changes
Does this address any currently open issues?
1251
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart: