Closed roomrys closed 1 year ago
Merging #1404 (1eae024) into develop (0e7a372) will increase coverage by
0.00%
. The diff coverage is83.33%
.
@@ Coverage Diff @@
## develop #1404 +/- ##
========================================
Coverage 72.73% 72.74%
========================================
Files 133 133
Lines 23719 23723 +4
========================================
+ Hits 17252 17257 +5
+ Misses 6467 6466 -1
Impacted Files | Coverage Δ | |
---|---|---|
sleap/gui/commands.py | 60.91% <83.33%> (+0.16%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Description
In #1265 while moving the dock creation logic outside the
MainWindow
class, a critical line was overlooked: https://github.com/talmolab/sleap/blob/0e7a3725d5e238b97f5daa35795829a15cd156db/sleap/gui/commands.py#L1955The
MainWindow.skeletonTemplates
attribute was renamed toMainWindow.skeleton_dock.skeleton_templates
, but this line (untested due to its GUI nature) was left behind.This PR corrects the line above to correctly call the
Video_Dock.skeleton_templates
attribute. While we do not test theOpenSkeleton.ask
method where the error originated from, this PR moves the code used to get the filename to a staticmethod on theOpenSkeleton
class which is called in the docks tests. The code has also been manually tested to run through theOpenSkeleton.ask
method and works as expected.Types of changes
Does this address any currently open issues?
1402
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart: