Closed roomrys closed 1 year ago
Merging #1435 (d48935b) into shrivaths/remove-last-video-fix (380a44b) will decrease coverage by
0.02%
. The diff coverage is70.00%
.
@@ Coverage Diff @@
## shrivaths/remove-last-video-fix #1435 +/- ##
===================================================================
- Coverage 73.04% 73.03% -0.02%
===================================================================
Files 133 133
Lines 23762 23768 +6
===================================================================
+ Hits 17358 17359 +1
- Misses 6404 6409 +5
Files Changed | Coverage Δ | |
---|---|---|
sleap/gui/widgets/video.py | 64.34% <0.00%> (-0.74%) |
:arrow_down: |
sleap/gui/app.py | 75.38% <100.00%> (+0.07%) |
:arrow_up: |
sleap/gui/overlays/base.py | 58.97% <100.00%> (+5.02%) |
:arrow_up: |
sleap/gui/overlays/tracks.py | 66.92% <100.00%> (+0.78%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Description
Previously, overlays had an open reference even after they were cleared from the player. This PR Ensures that when
QtVideoPlayer.reset
is called, thechangedPlot
signal is emitted which handles overlays and gui states.Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart: