Closed roomrys closed 1 year ago
Merging #1540 (c8e9a8e) into develop (ed77b49) will decrease coverage by
0.01%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## develop #1540 +/- ##
===========================================
- Coverage 73.39% 73.39% -0.01%
===========================================
Files 134 134
Lines 23961 23961
===========================================
- Hits 17586 17585 -1
- Misses 6375 6376 +1
Files | Coverage Δ | |
---|---|---|
sleap/gui/app.py | 75.34% <ø> (ø) |
|
sleap/gui/widgets/video.py | 64.34% <50.00%> (ø) |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
The proposed changes primarily focus on refining the user interface and improving the user experience. They include minor adjustments such as removing empty lines and unnecessary conditions, as well as significant modifications related to zoom behavior, event handling, and graphical element manipulation.
File Path | Summary |
---|---|
sleap/gui/app.py |
An empty line was removed in the dropEvent method. |
sleap/gui/widgets/video.py |
Various changes were made, including adjustments to zoom behavior, event handlers, and function calls. Also, the creation and manipulation of graphical elements were updated. |
🐇
In the land of code, where the brackets lie,
Changes small and large, under the digital sky.
Zooming, dropping, handling events,
Each line of code, makes a difference immense.
So here's to the coder, with their keen sight,
Making the user's journey, ever so light. 🎉
This needs to be revisited with a different approach
Description
This PR allows zooming with the trackpad on a laptop. Zooming with the trackpad actually passes a MouseButton into the events.buttons(), so previously this was being passed over in the wheelEvent.
Now, we just check that the event modifier is not the Alt key (which is the only other action that uses the wheelEvent - for rotating an instance about a node).
Types of changes
Does this address any currently open issues?
1528
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart:
Summary by CodeRabbit
sleap/gui/widgets/video.py
for improved code readability and maintainability.sleap/gui/widgets/video.py
to streamline the code.sleap/gui/widgets/video.py
for a more intuitive user experience.sleap/gui/widgets/video.py
for better UI consistency.