Closed roomrys closed 10 months ago
The updates to the codebase revolve around enhancing the triangulation process in a GUI application. The TriangulateSession
class has been improved with new methods for instance grouping and coordinate reprojection. The do_action
and update_instances
methods have been modified to use these enhancements. Refactoring has made the verification of views and instances more robust, and the handling of multi-instance products has been refined. Overall, the changes aim to improve the accuracy and efficiency of the triangulation workflow.
Files | Summary |
---|---|
.../gui/commands.py |
Introduced permutations from itertools , refactored do_action , verify_views_and_instances , and update_instances methods; added get_instance_grouping_and_reprojected_coords and _get_instance_grouping methods to TriangulateSession . |
.../gui/test_commands.py |
Updated TriangulateSession method calls and parameters; replaced get_instance_grouping with _get_instance_grouping and adjusted its logic; changed parameters for get_and_verify_enough_instances , update_instances , get_products_of_instances , and calculate_error_per_frame methods. |
🐇 In the realm of code, where triangles align,
A rabbit hopped through, refactoring fine.
With each leap and bound, errors took flight,
🌟 Magic in numbers—triangulation's delight! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: 8 lines
in your changes are missing coverage. Please review.
Comparison is base (
1b21838
) 73.85% compared to head (a3aca14
) 73.81%.
Files | Patch % | Lines |
---|---|---|
sleap/gui/commands.py | 84.61% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This method adapts the instance grouping to consider mutliple instances per frame instead of just a single instance per frame.
Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart:
Summary by CodeRabbit
New Features
Refactor
TriangulateSession
for better performance and maintainability.Bug Fixes