coderabbitai[bot]
commented
5 months ago Walkthrough
This update enhances the handling of instances within frame groups in the SLEAP project. It introduces refined logic for adding and removing instances, ensuring proper management and linking of these instances in various structures, thus improving the software's robustness and functionality in tracking scenarios.
Changes
| Files | Change Summary |
|---|---|
sleap/gui/commands.pysleap/io/dataset.py |
Added and refined logic for handling instances in FrameGroup, including addition, replacement, and removal of instances. |
sleap/io/cameras.py |
Refined instance handling in FrameGroup to ensure proper linking without an InstanceGroup. |
Possibly related issues
- Issue #1651: The changes in handling instances in frame groups might indirectly support the robustness required for ensuring all frames are accounted for, even if indirectly related to the specific enhancements requested for analysis export. The improved instance management could facilitate better data consistency, which is crucial for tools like SimBA that depend on comprehensive frame data.
🐇🎉 Oh hooray, oh joy, let's hop and twirl, For code that's neat as a bunny's whirl. Instances join, and none shall miss, In frame groups' dance, a coder's bliss. 🌟🐾
Recent Review Details
**Configuration used: CodeRabbit UI** **Review profile: CHILL**Commits
Files that changed from the base of the PR and between 8d3e232352d0665db2fd5eb65e3d55d83dbc139a and 0b3adbf4a7b61ef9ea38ca6b30c18aaecbe02508.Files selected for processing (3)
* sleap/gui/commands.py (1 hunks) * sleap/io/cameras.py (3 hunks) * sleap/io/dataset.py (2 hunks)Additional Context Used
Ruff (34)
sleap/gui/commands.py (11)
38-38: `itertools.permutations` imported but unused --- 38-38: `itertools.product` imported but unused --- 40-40: `typing.cast` imported but unused --- 57-57: `sleap.io.cameras.Camcorder` imported but unused --- 196-196: Undefined name `MainWindow` --- 834-834: Local variable `file_dir` is assigned to but never used --- 1708-1708: Do not use bare `except` --- 1729-1729: Do not use bare `except` --- 2466-2466: f-string without any placeholders --- 2798-2798: f-string without any placeholders --- 3161-3161: Do not use bare `except`sleap/io/cameras.py (7)
79-79: f-string without any placeholders --- 80-80: f-string without any placeholders --- 81-81: f-string without any placeholders --- 448-448: Undefined name `Skeleton` --- 601-601: Undefined name `Skeleton` --- 829-829: Do not use bare `except` --- 1003-1003: Undefined name `Labels`sleap/io/dataset.py (16)
55-55: Redefinition of unused `Callable` from line 45 --- 61-61: `h5py` imported but unused --- 69-69: Do not use bare `except` --- 70-70: `typing._ForwardRef` imported but unused --- 365-365: Do not assign a `lambda` expression, use a `def` --- 367-370: Do not assign a `lambda` expression, use a `def` --- 372-375: Do not assign a `lambda` expression, use a `def` --- 934-934: Do not compare types, use `isinstance()` --- 1484-1484: Do not compare types, use `isinstance()` --- 2389-2389: Undefined name `glob` --- 2484-2484: Avoid equality comparisons to `False`; use `if not ret:` for false checks --- 2572-2572: Avoid equality comparisons to `False`; use `if not ret:` for false checks --- 2587-2587: Undefined name `sleap` --- 2677-2677: Do not compare types, use `isinstance()` --- 2680-2680: Local variable `e` is assigned to but never used --- 2682-2682: f-string without any placeholders
Additional comments not posted (2)
sleap/io/cameras.py (1)
Line range hint `601-601`: The name `Skeleton` is undefined in this scope, which will cause a runtime error.sleap/gui/commands.py (1)
`2931-2950`: Ensure that the new instance is correctly added to the `InstanceGroup`. Please verify that the `InstanceGroup` and `FrameGroup` are correctly updated when a new instance is added. This is crucial for maintaining data integrity and ensuring that the GUI reflects the current state of the model.
codecov[bot]
Description
TriangulateSessioncallsframe_group.upsert_pointswhich should createPredictedInstances for anyCamcorders that do not already have an assignedInstance(orPredictedIntance). However, after triangulating, thePredictedInstances were not being displayed in the GUI - even though the containingInstanceGroupappeared to have been filled in withPredictedInstances for each "missing" view.This PR does 3 things:
PredictedInstances to theLabeledFramePredictedInstances withInstances (when creating anInstancefrom aPredictedInstance)InstancewithPredictedInstance(when removing anInstancethat ha an associatedPredictedInstance)Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart:
Summary by CodeRabbit