search

talmolab / sleap

A deep learning framework for multi-animal pose tracking.
https://sleap.ai
Other
427 stars 97 forks source link

(4a -> 4) Add double click functionality to UnlinkVideoTable #1763

Closed ramizhajj1 closed 4 months ago

ramizhajj1 commented 4 months ago

Description

Set SessionsDock.unlinked_videos_table.is_activatable = True so that state["unlinked_video"] is updated to the selected Video item in the SessionDock.unlinked_videos_table. Also make the callback for state[unlinked_video"] just update the state["video"] essentially making these states have the same callbacks.

Types of changes

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

Thank you for contributing to SLEAP!

:heart:

ramizhajj1 commented 4 months ago

I re-encoded the video.mp4 files using this command: ffmpeg -y -i "input.mp4" -c:v libx264 -pix_fmt yuv420p -preset superfast -crf 23 "output.mp4" and it seems that the videos are correctly loading when I double click them on the unlinked videos table.

https://github.com/talmolab/sleap/assets/122569822/62f20429-cab0-4621-a070-7f555a80e194

coderabbitai[bot] commented 4 months ago

[!WARNING]

Rate Limit Exceeded

@roomrys has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 9 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 561df753bb4562406abbc7f490e8c81a61819960 and 05889f9d937463b45487347715f2e678de967eae.

Walkthrough

The recent updates encompass various enhancements and modifications across multiple files in the SLEAP GUI application. These changes include improvements to video handling and GUI updates, addition of new encoding functions, and minor tweaks like adding print statements and blank lines. The modifications aim to improve functionality, maintainability, and user experience.

Changes

File(s) Change Summary
Anaconda3-2023.04-MacOSX-x86_64.sh Returns a 404 Not Found error message with details about the missing key.
sleap/gui/app.py Added methods for video handling and GUI updates, initialized GUI components, and set environment variables.
sleap/gui/commands.py Added an extra blank line at the end of the file.
sleap/gui/dataviews.py Added a print statement in the activateSelected method to display activation details.
sleap/gui/scripts/reencoder.py Introduced functions to encode videos using ffmpeg with specified parameters.
sleap/gui/widgets/docks.py Added is_activatable=True attribute to unlinked_videos_table and updated double-click handling.
sleap/gui/widgets/video.py Connected update_selection_state to "unlinked_video" signal and added a blank line in load_video.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant GUI
    participant VideoHandler
    participant Encoder

    User->>GUI: Opens video file
    GUI->>VideoHandler: Load video
    VideoHandler->>GUI: Update GUI with video

    User->>Encoder: Encode video
    Encoder->>User: Provide encoded video

Poem

In the code where pixels play,
Videos dance and signals sway.
GUI refreshed, with views anew,
Encoding magic, just for you.
A rabbit hops in lines so neat,
Making SLEAP a coder's treat.
🌟✨🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.08%. Comparing base (ddeb083) to head (05889f9).

Files Patch % Lines
sleap/gui/widgets/video.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## liezl/add-gui-elements-for-sessions #1763 +/- ## ==================================================================== Coverage 74.07% 74.08% ==================================================================== Files 135 135 Lines 25261 25264 +3 ==================================================================== + Hits 18713 18716 +3 Misses 6548 6548 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.