talmolab / sleap

A deep learning framework for multi-animal pose tracking.
https://sleap.ai
Other
435 stars 97 forks source link

View Hyperparameter nonetype fix #1766

Closed shrivaths16 closed 6 months ago

shrivaths16 commented 6 months ago

Description

Previously, while trying to view the hyperparameters of trained models, the window did not open and threw a NoneType error. This was due to the cfg_getter that was not passed from the metrics.py to the dialogs.py in order to fetch the configs file to read the hyperparameters. Hence, passing the cfg_getter to avoid the NoneType error.

Types of changes

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

Thank you for contributing to SLEAP!

:heart:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.09%. Comparing base (7ed1229) to head (4cbd34a). Report is 3 commits behind head on develop.

Files Patch % Lines
sleap/gui/dialogs/metrics.py 0.00% 1 Missing :warning:
sleap/gui/learning/dialog.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1766 +/- ## =========================================== + Coverage 73.30% 74.09% +0.78% =========================================== Files 134 134 Lines 24087 24459 +372 =========================================== + Hits 17658 18123 +465 + Misses 6429 6336 -93 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.