talmolab / sleap

A deep learning framework for multi-animal pose tracking.
https://sleap.ai
Other
427 stars 97 forks source link

Add ZMQ support via GUI and CLI #1780

Closed shrivaths16 closed 4 months ago

shrivaths16 commented 4 months ago

Description

Adding ZMQ port options in the GUI and CLI for having ease of specifying the ports. Previously, if a port was occupied users had to change it each time by manually editing the training config each time. This feature saves time by specifying the ports in the GUI.

Types of changes

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

Thank you for contributing to SLEAP!

:heart:

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent changes introduce configurable ZeroMQ ports for the SLEAP GUI, allowing users to specify ports for controller and publish addresses. This flexibility helps avoid conflicts when running multiple instances of SLEAP. Enhancements include new utility functions for port management, updated class constructors, and command-line argument modifications to support this feature.

Changes

File Summary of Changes
sleap/gui/learning/runners.py Added inference_params parameter to several functions, introduced zmq_ports for handling ports, and updated LossViewer instantiation.
sleap/gui/utils.py Introduced utility functions is_port_free and select_zmq_port for port management.
sleap/gui/widgets/monitor.py Modified LossViewer class to accept zmq_ports and updated setup_zmq method to use these ports.
sleap/nn/training.py Added command-line arguments --publish_port and --controller_port for ZeroMQ port customization.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant GUI
    participant LossViewer
    participant TrainingProcess

    User->>GUI: Launch SLEAP GUI
    GUI->>GUI: Select free ports using `select_zmq_port`
    GUI->>LossViewer: Instantiate with `zmq_ports`
    User->>GUI: Start training
    GUI->>TrainingProcess: Pass `controller_port` and `publish_port`
    TrainingProcess->>LossViewer: Send updates via ZeroMQ
    LossViewer->>User: Display training progress

Possibly related issues

Poem

In the realm of SLEAP, where data flows, Ports now dance, as the user knows. No more conflicts, no more fight, ZeroMQ ports set just right. Training runs smooth, a joyous sight, Thanks to changes, coding bright!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to full the review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 40.47619% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 74.04%. Comparing base (7ed1229) to head (ff9aa16). Report is 8 commits behind head on develop.

Files Patch % Lines
sleap/gui/utils.py 21.05% 15 Missing :warning:
sleap/gui/learning/runners.py 0.00% 6 Missing :warning:
sleap/gui/widgets/monitor.py 69.23% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1780 +/- ## =========================================== + Coverage 73.30% 74.04% +0.73% =========================================== Files 134 135 +1 Lines 24087 24500 +413 =========================================== + Hits 17658 18140 +482 + Misses 6429 6360 -69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.