Closed shrivaths16 closed 5 months ago
The recent changes in the sleap
GUI application focus on renaming functionalities related to deleting predictions. Specifically, the menu item and associated actions have been updated from "delete frame limit predictions" to "delete max instance predictions." This change reflects a shift in terminology to better describe the action of deleting predictions that exceed a certain instance limit.
File(s) | Change Summary |
---|---|
sleap/gui/app.py |
Updated menu item label from "delete frame limit predictions" to "delete max instance predictions". |
sleap/gui/commands.py |
Renamed function deleteFrameLimitPredictions to deleteInstanceLimitPredictions and class DeleteFrameLimitPredictions to DeleteInstanceLimitPredictions . |
sequenceDiagram
participant User
participant GUI
participant Commands
User->>GUI: Click "delete max instance predictions"
GUI->>Commands: Call deleteInstanceLimitPredictions()
Commands-->>GUI: Execute deletion logic
GUI-->>User: Update UI to reflect deletions
In the code where changes flow,
Predictions now have a new show.
From frames to instances, they shift,
A refined name gives them a lift.
Deletion's clearer, precise and neat,
Our GUI's now a greater feat!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 66.66667%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 74.06%. Comparing base (
7ed1229
) to head (4062624
). Report is 9 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
sleap/gui/commands.py | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Currently we have a menu option
Delete Predictions beyond Frame Limit...
but it is misleading as it asks for the max instances beyond which the predictions are deleted. Hence changing the menu name toDelete Predictions beyond Max Instances...
to be clear. Also, changed the related function names to reflect the same.This could potentially clear the confusion related to #1762
Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart: