Closed roomrys closed 2 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 93.42105%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 74.16%. Comparing base (
475283d
) to head (c6cd295
).
Files | Patch % | Lines |
---|---|---|
sleap/util.py | 92.85% | 3 Missing :warning: |
sleap/gui/dataviews.py | 33.33% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR does 3 main things (described in more detail further down):
PredictedInstance.score
sInstanceGroup.score
attributeInstanceGroup.score
in tableAdditionally, to use the
sleap.nn.evals.compute_oks
function inside asleap.io
file, we needed to move thecompute_oks
function tosleap.util
to avoid a circular import betweensleap.nn
andsleap.io
files.Use same OKS score for all
PredictedInstance.score
sPreviously, all the
PredictedInstances
created and updated through (re)projection had a default nan score. This PR uses an average oks (calculated from ground truthInstance
s and their reprojections) as the score for all (re)projectedPredictedInstance
s.Add
InstanceGroup.score
attributeTo be most correct, even the
Instance
s which have reprojected nodes should have a score associated with them. There is currently noInstance.score
attribute, and since this score really applies to the entireInstanceGroup
(not just thePredictedInstance
s in theInstanceGroup
), this PR also adds anInstanceGroup.score
attribute that is updated each time we callInstanceGroup.update_points
.Display
InstanceGroup.score
in tableThis
InstanceGroup.score
is likely the most useful information for users to see, so this PR also adds a score column to the table displaying InstanceGroup information.Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart: