Closed roomrys closed 2 months ago
[!IMPORTANT]
Review skipped
Review was skipped as selected files did not have any reviewable changes.
Files selected but had no reviewable changes (2)
* sleap/io/asyncvideo.py * tests/io/test_asyncvideo.pyYou can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.34%. Comparing base (
7ed1229
) to head (9a0dc30
). Report is 38 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
In a downstream branch where we update dependencies,
AsyncVideo
is giving us some troubles. Namely, thetest_asyncvideo
function is hanging up on both Linux and Mac (this test has always been skipped if Windows). Of course, we are up for the challenge of figuring out what the matter might be, but further investigation revealed that theAsyncVideo
class is not being used anywhere in our codebase. Instead, we use theLoadImageWorker
class to load video frames ina background thread.Thus, this PR simply removes the unused and broken-in-a-downstream-branch
AsyncVideo
class.Types of changes
Does this address any currently open issues?
1841
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart: