Closed eberrigan closed 3 weeks ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
imagio-ffmpeg
platform-specific wheels are only available for Windows and macos but excluding Silicon macs!imageio-ffmpeg PyPI documentation
“”””Note that the platform-specific wheels contain the binary executable of ffmpeg, which makes this package around 60 MiB in size. I guess that’s the cost for being able to read/write video files.
For Linux users: the above is not the case when installing via your Linux package manager (if that is possible), because this package would simply depend on ffmpeg in that case”””
This causes the following tests to fail when running
build_ci
on the silicon macs and ubuntu runners which tests the built SLEAP PyPI wheel:This does not happen for our CI tests, which test the
conda
environments across OS's becauseimagio-ffmpeg
installed via conda-forge pulls in the correctconda
install offfmpeg
while resolving the environment. This should is also the case for our builtconda
packages.ffmpeg 7.0.2 gpl_h226ea3b_102 conda-forge
,imageio-ffmpeg 0.5.1 pyhd8ed1ab_0 conda-forge
ffmpeg 6.1.2 gpl_h3ef3969_102 conda-forge
,imageio-ffmpeg 0.5.1 pyhd8ed1ab_0 conda-forge
ffmpeg 6.1.2 gpl_h9cf63cc_102 conda-forge
,imageio-ffmpeg 0.5.1 pyhd8ed1ab_0 conda-forge
This issue for the PyPI runners can be remedied by installing
ffmpeg
as part of the github action workflow.Anaconda documentation for ffmpeg conda package
Types of changes
Does this address any currently open issues?
GA workflows failing for ubuntu and silicon mac runners #1923.
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart: