coderabbitai[bot]
commented
2 months ago Walkthrough
The changes introduce a new GitHub Actions workflow for building and testing a Conda package across multiple operating systems. Additionally, the existing PyPI workflow is updated to reflect a more specific focus on PyPI tasks, with minor formatting improvements. These modifications aim to streamline the automation processes related to package building and testing.
Changes
| Files | Change Summary |
|---|---|
.github/workflows/build_conda_ci.yml |
Introduced a new workflow for automating Conda package building and testing across Windows, Ubuntu, and macOS. Defines build and tests jobs with matrix strategy and conditional steps. |
.github/workflows/build_pypi_ci.yml |
Updated workflow name to "Build PyPI CI (no upload)" and reformatted paths to use double quotes; minor formatting adjustments made for consistency. |
Sequence Diagram(s)
sequenceDiagram
participant Developer
participant GitHub Actions
participant Conda Environment
participant Test Environment
Developer->>GitHub Actions: Push changes
GitHub Actions->>Conda Environment: Set up environment
GitHub Actions->>Conda Environment: Build Conda package
Conda Environment-->>GitHub Actions: Upload artifacts
GitHub Actions->>Test Environment: Set up testing environment
Test Environment-->>GitHub Actions: Run tests🐇 In fields of green, I hop with glee,
New workflows bloom, as bright as can be!
Conda builds and tests, oh what a sight,
PyPI shines, all polished and bright!
With each little change, our code takes flight,
Hooray for the updates, everything feels right! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Previously, we added a workflow in
build_ci.ymlwhich builds and installs SLEAP via the PyPI wheel and then runs our unit tests.In this PR, we add another workflow in
build_conda_ci.ymlthat builds and installs SLEAP through the conda package and then runs our unit tests. Also, I renamedbuild_ci.ymltobuild_pypi_ci.yml. I opted not to bundle the conda package build tests with the pypi build tests as they have some non-overlapping triggers (and the conda build is extremely expensive).However, note that both these workflows use artifact-upload/download between build and test jobs which means that we could download the passing build packages from the provided link in action and use those to upload to conda and PyPI (instead of rebuilding in
build.ymlandbuild_manual.yml).Currently, all package tests fail with:
when we attempt to
. A repo search of develop shows that
imageio-ffmpegwas added as a dependency to the environment yamls, but not to the meta yamls that build the conda packages. This PR does not fix this. Instead #1943 fixes this.Types of changes
Does this address any currently open issues?
1943
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart:
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Improvements