search

talmolab / sleap

A deep learning framework for multi-animal pose tracking.
https://sleap.ai
Other
435 stars 97 forks source link

Remove no module named work error #1956

Closed roomrys closed 2 months ago

roomrys commented 2 months ago

Description

When upgrading a few of our dependendencies (in SLEAP >1.3.3), we started getting this message printed in the terminal:

liezlmaree:~$ sleap-label
Saving config: /Users/liezlmaree/.sleap/1.4.1a2/preferences.yaml
Error occurred during callback 0 for color predicted!
[<built-in method setChecked of PySide2.QtWidgets.QAction object at 0x2b79e8c00>, <function MainWindow._load_overlays.<locals>.overlay_state_connect.<locals>.<lambda> at 0x2bafb8430>, <bound method MainWindow.plotFrame of <sleap.gui.app.MainWindow(0x2aaf84720) at 0x2b6ec9e80>>]
No module named 'work'
Restoring GUI state...
Error occurred during callback 0 for color predicted!
[<built-in method setChecked of PySide2.QtWidgets.QAction object at 0x2b79e8c00>, <function MainWindow._load_overlays.<locals>.overlay_state_connect.<locals>.<lambda> at 0x2bafb8430>, <bound method MainWindow.plotFrame of <sleap.gui.app.MainWindow(0x2aaf84720) at 0x2b6ec9e80>>, <function MainWindow._load_overlays.<locals>.overlay_state_connect.<locals>.<lambda> at 0x2bafd9940>, <bound method MainWindow.plotFrame of <sleap.gui.app.MainWindow(0x2aaf84720) at 0x2b6ec9e80>>]
No module named 'work

. While the appearance of this error message also coincided with the GUI crashing on a mouseWheel event (zooming in/out), these errors are actually two different errors both caused by the same update. The GUI-crash-on-scroll issue was much more debilitating, but this error message printing in the terminal is just cosmetically annoying.

We don't want to release a release where we have this new annoying message in the terminal that appears everytime someone clicks a check button. So... this PR investigates this issue and removes the error message seen above without taking away any GUI functionality.

Types of changes

Does this address any currently open issues?

Outside contributors checklist

Thank you for contributing to SLEAP!

:heart:

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve modifications to the add_menu_item function in sleap/gui/app.py, where a lambda function is introduced to handle the connection of the state variable to the menu action's setChecked method. Additionally, the toggle_and_verify_visibility function in tests/gui/test_app.py is enhanced with assertions to verify the menu item's checked state against the "color predicted" state in the window.

Changes

File Change Summary
sleap/gui/app.py Modified the add_menu_item function to use a lambda function for connecting the state variable to the setChecked method of the menu action.
tests/gui/test_app.py Enhanced the toggle_and_verify_visibility function by adding assertions that verify the menu item's checked state against the "color predicted" state.

Possibly related issues

🐇 In the garden, I hop with glee,
A menu's state, now clear as can be!
With checks and toggles, all in line,
The code is tidy, oh how it shines!
So let's celebrate with a joyful cheer,
For every change brings us near! 🌼

[!TIP]

Announcements - The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment. - We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the [discussion post](https://discordapp.com/channels/1134356397673414807/1279579842131787838) on our Discord. - Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the [discussion post](https://discordapp.com/channels/1134356397673414807/1282535539299323995) on our Discord. - Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file. - Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 91d6c96dd77bc092d7835046245fb787b444523d and 93e0aa2932e07abdbb6e92689bf42cc5553057c4.
Files selected for processing (2) * sleap/gui/app.py (1 hunks) * tests/gui/test_app.py (1 hunks)
Additional comments not posted (2)
tests/gui/test_app.py (1)
`417-422`: **LGTM!** The new assertions comprehensively verify that the menu item's checked state stays in sync with the window's "color predicted" state.
sleap/gui/app.py (1)
`380-382`: **LGTM!** The change to use a lambda function for connecting the menu item's checked state to the state variable is a good improvement. It provides more flexibility for future modifications without changing the core connection logic.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.34%. Comparing base (7ed1229) to head (93e0aa2). Report is 50 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1956 +/- ## =========================================== + Coverage 73.30% 75.34% +2.03% =========================================== Files 134 133 -1 Lines 24087 24476 +389 =========================================== + Hits 17658 18441 +783 + Misses 6429 6035 -394 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.