Open roomrys opened 23 hours ago
[!IMPORTANT]
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.99%. Comparing base (
7ed1229
) to head (a4da7b1
). Report is 53 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
In #1970, we created our own
SkeletonEncoder
class to move away from usingjsonpickle.encode
. And, while theSkeletonEncoder
paired with theSkeletonDecoder
works perfectly fine, we get some strange behavior when trying to loadSkeleton
jsons across versions of SLEAP (that still usejsonpickle.decode
).The only difference seemed to be the ordering of the keys in the dictionaries; thus, this PR sorts the
Skeleton
dictionaries before encoding them - which has proven to do the trick with some manual testing across versions.Unsorted skeleton (breaks backwards compatibility)
Sorted skeleton (backwards compatible)
v1.3.3 Skeleton
Types of changes
Does this address any currently open issues?
1972
1970
1961
1841
Outside contributors checklist
Thank you for contributing to SLEAP!
:heart: