talonhub / community

Voice command set for Talon, community-supported.
MIT License
656 stars 784 forks source link

app_name_overrides not applied for "launch" commands #1527

Open peagha opened 4 months ago

peagha commented 4 months ago

Hello folks! first of all congrats on the awesome work you have done with talon and talon community 💟

I have made changes to app_name_overrides and they work with focus commands but it seems to have no support for launch commands. I went through the code and it seems that it was not implemented.

knausj85 commented 3 days ago

I think the app_switcher is generally in need of a redesign/refactor.

Ideally, I think we would do the following:

  1. On MacOS, parse the Info.plist file for apps and get the bundle identifier / executable. Maybe.
  2. On Windows, attempt to parse the shortcuts in the shell:applications folder to retrieve both the AppUserModelId (required for Windows Store apps) and the target path for the shortcut (ideal for standard apps).

I have not had luck figuring out how to parse the shortcuts yet, but the rest works.

This would allow us to more robustly override these things in both places via

in a robust way. Probably in that order.

If we can't figure out item 2, worst case we could have an entry for both AppUserModelId and the exe

I'm slightly inclined to move away from CSVs for this in favor of something similar to code_languages.py

I don't know how this stuff would translate to linux.