Revert using software=True on linux

talonhub / community

Voice command set for Talon, community-supported.

MIT License

624 stars 780 forks source link

Revert using software=True on linux #335

Closed rntz closed 3 years ago

rntz commented 3 years ago

Now that https://github.com/talonvoice/talon/issues/190 is fixed, we should be able to use imgui.open(software=False) by default everywhere again. I haven't tested this on my box yet, though.

lunixbochs commented 3 years ago

software= for both imgui and canvas is being deprecated in v0.1.5 fyi. I recommend just removing it. v0.1.4 fixed the crashing and flickering issues with software=False, and v0.1.5 will fix the memory leak.

There is a replacement parameter, but I would prefer to not hardcode the backend type at call sites, so if there's an ongoing need for this I will look into a global setting.

rntz commented 3 years ago

Ok, I'll try just deleting them tonight and see whether I still have any issues.

rntz commented 3 years ago

Seems to work for me. Made a PR.

rntz commented 3 years ago

oh woops, looks like @knausj85 beat me to it :)