search

talonhub / community

Voice command set for Talon, community-supported.
MIT License
621 stars 770 forks source link

open csvs in utf8 mode #401

Closed rntz closed 3 years ago

rntz commented 3 years ago

e.g. open(path, 'r', encoding='utf8')

Slack link: https://talonvoice.slack.com/archives/C7ENXA7C4/p1616876829071900?thread_ts=1616876356.067400&channel=C7ENXA7C4&message_ts=1616876829.071900

Seems like this broke someone's additional_words.csv

knausj85 commented 3 years ago

I believe this is most likely a talon bug, as I was under the impression it forced utf8. I’ve tested around this on Mac and Windows

resource.open also doesn’t have an encoding parameter IIRC

On Sat, Mar 27, 2021 at 11:53 PM Michael Arntzenius < @.***> wrote:

e.g. open(path, 'r', encoding='utf8')

Slack link: https://talonvoice.slack.com/archives/C7ENXA7C4/p1616876829071900?thread_ts=1616876356.067400&channel=C7ENXA7C4&message_ts=1616876829.071900

Seems like this broke someone's additional_words.csv

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/knausj85/knausj_talon/issues/401, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSPSBGQOKWQI4L3Q75DQJTTF3G45ANCNFSM4Z5WAKFQ .

rntz commented 3 years ago

Yes, there seems to be further debugging happening in this slack thread. Closing this.