talonhub / community

Voice command set for Talon, community-supported.
MIT License
604 stars 764 forks source link

Migrate existing terminal implementations to new architecture from #505 #562

Open DonnerWolfBach opened 2 years ago

DonnerWolfBach commented 2 years ago

In #505 a new "architecture" for how terminal should be supported/implemented was defined. However, not all existing implementations where migrated to this new style yet. This issue will contain a list of the missing and already migrated terminals.

Linux:

Mac:

Windows:

The implementation of kde-konsole serves as a reference of how it should/could be done.

DonnerWolfBach commented 2 years ago

@fidgetingbits should we remove termite from the list and add alacritty instead?

fidgetingbits commented 2 years ago

may as well just have both termite and alacritty I think, just because it's deprecated doesn't mean people won't use it since it's still stable, and no real harm in keeping it imo.

DonnerWolfBach commented 2 years ago

For everybody in need of an explanation of the new "terminal architecture", here the summary from here: generic_terminal.talon lists some commands that should be possible in every terminal, like lisa (list directories). generic_windows_shell and generic_unix_shell.py provide the implementations for these commands (there are major enough differences between windows shells and unixoid shells). Everything else, like tab support, activation of specific commands sets(like git,anaconda,kubectl) is done in the .talon and .py files for the specific terminals.

rntz commented 2 years ago

Is this done yet? What's its current state if not?

DonnerWolfBach commented 2 years ago

@rntz Still work in progress, but powershell and windows powershell is finished and waits to be merged: #711