talonhub / community

Voice command set for Talon, community-supported.
MIT License
643 stars 783 forks source link

Look into simplifying formatters #768

Closed rntz closed 3 days ago

rntz commented 2 years ago

The current formatter code is kind of yucky, and has several minor faults:

  1. Formatter immune stuff doesn't play nicely with history - it invokes format_phrase multiple times instead of just once, creating multiple history entries.
  2. The way formatters are represented is just kinda ugly.
  3. Unformatting doesn't handle snake_case.

Andreas Arvidsson completely rewrote them (https://github.com/AndreasArvidsson/andreas-talon/blob/master/text/text.talon, https://github.com/AndreasArvidsson/andreas-talon/blob/master/text/formatters.py). Perhaps something along those lines would be better?

rntz commented 2 years ago

Some concerns about formatter behaviour that are relevant: #539 #674 #616 #539

knausj85 commented 3 days ago

Addressed by https://github.com/talonhub/community/pull/1431