talonlab / python-hdwallet

Python-based library for the implementation of a Hierarchical Deterministic (HD) Wallet generator supporting more than 200 cryptocurrencies.
https://hdwallet.readthedocs.io
MIT License
461 stars 151 forks source link

Invalid derivation paths in the documentation #80

Closed streamofstars closed 13 hours ago

streamofstars commented 1 year ago

DISCLAIMER: I tried editing the documentation myself but github forces me to fork the project first and when I try to do that I get 404 page. I have no time to diagnose that, so please someone either with direct access or who just knows better than me how to work with github, fix the below.

The documentation page under this address specifically https://hdwallet.readthedocs.io/en/v2.2.1/hdwallet.html on multiple occasions include invalid derivation paths. Please double check all of them, I just copied one example to the code I'm working on and stumbled upon this m/44'/0'/'0/0/0 which is obviously broken as there is hardening symbol before second zero from the left instead of being after it. If you ctrl+f and search for it in the article, you will find that such a broken path is used 7 times. The proper path is m/44'/0'/0'/0/0.